Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data analysts should be able to Text.match, Text.match_all, Text.is_match to find or check matches #3841

Merged
merged 17 commits into from
Nov 18, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Oct 31, 2022

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181266092

Important Notes

Also renaming Text.location_of and Text.location_of_all to Text.locate and Text.locate_all.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@radeusgd radeusgd force-pushed the wip/radeusgd/text-match-refactor-181266092 branch from a18c390 to 0a74ba1 Compare October 31, 2022 22:53
@radeusgd radeusgd self-assigned this Oct 31, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/text-match-refactor-181266092 branch 2 times, most recently from dc73edc to ac25224 Compare November 3, 2022 13:45
@radeusgd radeusgd force-pushed the wip/radeusgd/text-match-refactor-181266092 branch 2 times, most recently from 56f3c31 to b24ece6 Compare November 16, 2022 11:35
@radeusgd radeusgd marked this pull request as ready for review November 16, 2022 11:48
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not quite sure on the name for locate / locate_all but otherwise looks good and if we come up with a better name can rename.

@radeusgd radeusgd force-pushed the wip/radeusgd/text-match-refactor-181266092 branch from 1c2ed14 to 0706383 Compare November 18, 2022 09:55
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Nov 18, 2022
@mergify mergify bot merged commit 5b6fd74 into develop Nov 18, 2022
@mergify mergify bot deleted the wip/radeusgd/text-match-refactor-181266092 branch November 18, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants