-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data analysts should be able to Text.match
, Text.match_all
, Text.is_match
to find or check matches
#3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/text-match-refactor-181266092
branch
from
October 31, 2022 22:53
a18c390
to
0a74ba1
Compare
radeusgd
force-pushed
the
wip/radeusgd/text-match-refactor-181266092
branch
2 times, most recently
from
November 3, 2022 13:45
dc73edc
to
ac25224
Compare
radeusgd
force-pushed
the
wip/radeusgd/text-match-refactor-181266092
branch
2 times, most recently
from
November 16, 2022 11:35
56f3c31
to
b24ece6
Compare
jdunkerley
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not quite sure on the name for locate
/ locate_all
but otherwise looks good and if we come up with a better name can rename.
radeusgd
force-pushed
the
wip/radeusgd/text-match-refactor-181266092
branch
from
November 18, 2022 09:55
1c2ed14
to
0706383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/181266092
Important Notes
Also renaming
Text.location_of
andText.location_of_all
toText.locate
andText.locate_all
.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.