-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a VCS save on ctrl+s shortcut #3923
Make a VCS save on ctrl+s shortcut #3923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve from my side, but someone knowing our backend should check it as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if someone wants to save a project with a particular name, that's gonna be a different operation?
code: error_code, .. | ||
})) = response | ||
{ | ||
if error_code == code::FILE_NOT_FOUND { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is FILE_NOT_FOUND? I need to change that so that it returns VCSNotFound
.. sorry!
Do you mean the |
The latter. I suppose there will be a follow up ( |
Ok, yes. If I understand correctly the first step is to implement basic snapshot/restore functionality, which can be expanded to named snapshots later. |
QA process passed, have a nice day! |
Pull Request Description
Save a snapshot of the project directory to the VCS on
ctrl+s
. If the operation fails because the VCS was not initialized previously, it will try to initialize the VCS first and then save a snapshot.Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.