-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arbitrary expression evaluation in chromeinspector #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # engine/runtime/src/main/scala/org/enso/compiler/Compiler.scala
Akirathan
force-pushed
the
wip/akirathan/expr-eval-183855919
branch
from
December 2, 2022 15:10
bff76ad
to
2385f88
Compare
Akirathan
requested review from
4e6,
JaroslavTulach and
hubertp
as code owners
December 6, 2022 14:59
hubertp
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
engine/runtime/src/main/java/org/enso/interpreter/EnsoLanguage.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
approved these changes
Dec 7, 2022
engine/runtime/src/main/java/org/enso/interpreter/instrument/HostObjectDebugWrapper.java
Show resolved
Hide resolved
Akirathan
added
CI: Ready to merge
This PR is eligible for automatic merge
and removed
CI: Ready to merge
This PR is eligible for automatic merge
labels
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Allow arbitrary expression evaluation in the chromeinspector console. Moreover, allow modifications of any variable in any stack frame.
Important Notes
EnsoLanguage.parse(InlineParsingRequest)
.docs/debugger
.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.