Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary expression evaluation in chromeinspector #3941

Merged
merged 28 commits into from
Dec 7, 2022

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Dec 1, 2022

Pull Request Description

Allow arbitrary expression evaluation in the chromeinspector console. Moreover, allow modifications of any variable in any stack frame.

Important Notes

  • Implement inline parsing in EnsoLanguage.parse(InlineParsingRequest).
  • Debugging experience is affected by this bug in Truffle, which causes NPEs when a host object gets into chromeinspector. I tried to implement a workaround, but it does not work all the time. Nevertheless, it should not matter that much - if there is a NPE in the debugger, you can just ignore it, as it should be concealed in the debugger and should not be propagted outside. See comments in the docs/debugger.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@Akirathan Akirathan self-assigned this Dec 1, 2022
@Akirathan Akirathan force-pushed the wip/akirathan/expr-eval-183855919 branch from bff76ad to 2385f88 Compare December 2, 2022 15:10
@Akirathan Akirathan marked this pull request as ready for review December 6, 2022 14:59
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Dec 7, 2022
@Akirathan Akirathan added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Ready to merge This PR is eligible for automatic merge labels Dec 7, 2022
@mergify mergify bot merged commit 4641426 into develop Dec 7, 2022
@mergify mergify bot deleted the wip/akirathan/expr-eval-183855919 branch December 7, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants