-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add executionContext/interrupt API command #3952
Conversation
.option(RuntimeOptions.LOG_LEVEL, "WARNING") | ||
.option( | ||
RuntimeOptions.INTERPRETER_SEQUENTIAL_COMMAND_EXECUTION, | ||
"false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our runtime tests are sequential, i.e. all the commands sent to the engine are executed in sequence. It is a very useful property when testing the code because it prevents all kinds of race conditions.
Unforutnately, you cannot test the program interruption with the sequential flow because you need to send an interruption command while the previous command (execute program) is still in progress. That's why there is a new suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found the "forcibly stop program execution" implementation - I assume it already existed and this PR just makes it available via the protocol, right?
null; | ||
``` | ||
|
||
#### Errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably needs an update about ContextDoesNotExist?
@JaroslavTulach under the hood the logic calls ThreadManager.interruptThreads() method. I assume that this is the way to interrupt the program execution. |
Pull Request Description
Implement the
executionContext/interrupt
API command that forcibly stops the program execution.Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.