-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing visualization preview in CB #5757
Fix missing visualization preview in CB #5757
Conversation
@farmaazon
2023-02-27.17-46-22.mp4This PR is not the cause though, as it happens on develop as well (except it does not show preview on develop). The reason for such behavior is in our searcher implementation: We replace the expression with suggestion preview, and sometimes it is left in the code even though the the CB does not have any entries visible. Moreover, the previewed suggestion can be different at different times (perhaps it is caused by different ordering of filtered results when your enter different numbers). Otherwise the preview always shows the default value of index |
QA: accepted, given the said issues are also reproducible on develop. |
Pull Request Description
Closes #5639
This PR fixes a regression introduced in #4120, due to which new nodes that were being edited had an empty visualization preview. Now newly created visualization containers do get a default visualization set even before the visualization's input type is set.
unknown_2023.02.24-19.05.mp4
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.