Fix #6377: Change ctrl-r shortcut #6620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Procrat
force-pushed
the
wip/procrat/fix-ctrl-r-restore-6377
branch
from
dbfd564
to
3c053f6
Compare
Procrat
requested review from
MichaelMauderer,
wdanilo,
farmaazon,
kazcw and
mwu-tow
as code owners
wdanilo
approved these changes
May 10, 2023
This was referenced May 10, 2023
Procrat
added a commit
that referenced
this pull request
May 10, 2023
…ing-6287 * develop: Fix issues with missing sourcemaps (#6572) Fix asset delete; implement project delete and project rename (#6566) Fix #6377: Change ctrl-r shortcut (#6620) Add tests for Date.until, Date.next and Date.previous. (#6606) Improve `Non_Unique_Primary_Key` error, split file format detection into read/write, improve SQLite format detection (#6604) tokenize_to_columns or parse_to_columns results in a single column we shouldn't add the 1 (#6607) Fix node editing race condition (#6594) Add format to the in-memory Column (#6538) Fix dashboard issues (part 2) (#6511) Fix visualisation type selector artifacts rendered after node preview visualisation was closed. (#6575) Revert typescript CI Lint changes (#6602) Fix the Engine version check in GUI (#6570)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #6377: The fact that
ctrl-rwas restoring the project to potentially the initial state was confusing. This PR changes that shortcut toctrl-shift-r, as discussed in #6377.Note that:
ctrl-shift-rwas already taken by the re-execution shortcut, so that got thectrl-altmodifiers instead, along with the interruption shortcut for consistency.ctrl-alt-shift-rwas already taken by a shortcut to refresh the whole Electron app, so that wasn't available.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Unit tests have been written where possible../run ide build.