Show spinner when opening/creating a project, take #2 #6827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A project name or ID that is passed on the command line was initialised in the controller setup, before the presenters and views are set up. Now, we fully initialise the IDE before opening a project so we have control over the view while a project is being opened.
Procrat
force-pushed
the
wip/procrat/prolong-project-spinner-5505
branch
from
fb283d6
to
8216a26
Compare
Procrat
requested review from
MichaelMauderer,
wdanilo,
farmaazon,
kazcw and
mwu-tow
as code owners
farmaazon
approved these changes
May 24, 2023
QA Report: 🟡When opening project with a new dashboard, there is a brief moment when I see "Initializing project..." what suggests the loading spinner is hidden a bit too early. loading-screen-2023-05-25_14.20.56.mp4We could live with it, but it should be checked + I'm not sure if it isn't more prominent on weaker hardware. |
|
This is the regression issue: #6708
It's this one: 8216a26 |
* develop: Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771)
|
After discussion with @farmaazon, we decided to merge this as is since it contains useful changes, but not close the original issue since it's not resolved yet. |
|
@Procrat I've left a comment in the code but it's not displayed here: 
|
Procrat
added a commit
that referenced
this pull request
May 30, 2023
…le-6756-6804 * develop: (22 commits) Coalesce graph editor view invalidations (#6786) Append warnings extracted before tail call execution (#6849) Detect and override hooks of the same kind (#6842) Dynamic app resampling and better performance measurements. (#6595) Show spinner when opening/creating a project, take #2 (#6827) Infrastructure for testing inter project imports and exports (#6840) Only initialise visualisation chooser if it is used. (#6758) Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771) Update GraalVM to 22.3.1 JDK17 (#6750) Import/export syntax error have more specific messages (#6808) ...
farmaazon
added a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is almost the same as #6321, but it got reverted since it created an impactful regression.
To recap, this fixes #5505: A spinner with the Enso logo is now shown for most of the duration when opening and creating projects.\
The only new code is the last commit which ensure that it works when there is no project manager available.
Note that the value of the spinner is somewhat lessened with the new dashboard since some of the startup time is covered after clicking the play button in the dashboard but before opening the project.
With the old dashboard:
2023-05-24.13-18-16.online-video-cutter.com.mp4
With the new dashboard:
2023-05-24.13-19-26.online-video-cutter.com.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Unit tests have been written where possible../run ide build.