-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent incorrect application of list widget on incompatible expressions #6771
Conversation
6a6fed0
to
3c13ccc
Compare
app/gui/view/graph-editor/src/component/node/input/widget/list_editor.rs
Outdated
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/node/input/widget/list_editor.rs
Outdated
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/node/input/widget/list_editor.rs
Outdated
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/node/input/widget/list_editor.rs
Outdated
Show resolved
Hide resolved
QA Report 🔴
(The node's expression is
Similarly, here I cannot connect to "than", because the entire argument is selected: |
@farmaazon good catches! |
@farmaazon Fixed mentioned issues, ready for second QA round. Note that in above node with incorrect syntax, the right hand side "almost-vector" is not actually recognized as such due to how the expression is parsed. It is in fact not a even distinct subtree that could receive a single widget. Therefore it will not allow drag and drop. Simplified span-tree:
|
QA report 2: 🟢Issues fixed, no more found. |
6a7f283
to
9884907
Compare
* develop: Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771)
…le-6756-6804 * develop: (22 commits) Coalesce graph editor view invalidations (#6786) Append warnings extracted before tail call execution (#6849) Detect and override hooks of the same kind (#6842) Dynamic app resampling and better performance measurements. (#6595) Show spinner when opening/creating a project, take #2 (#6827) Infrastructure for testing inter project imports and exports (#6840) Only initialise visualisation chooser if it is used. (#6758) Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771) Update GraalVM to 22.3.1 JDK17 (#6750) Import/export syntax error have more specific messages (#6808) ...
Fixes #6760
Fixes #6747
Pull Request Description
Refactored the logic behind selecting appropriate widgets for span tree nodes. Now the bulk of it is moved into widget methods. When a given widget type is reporting to be not compatible with the expression, it will not be used even if the configuration was overriden using an method argument annotation. In that case, the usual logic for automatically selecting the appropriate widget will kick in.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.