Clearly select single specialization with enum dispatch pattern #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
5 tasks
…ithout negative hasType check
Akirathan
reviewed
May 24, 2023
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/TypeOfNode.java
Outdated
Show resolved
Hide resolved
|
Something is wrong with JSON conversions... 71ad4e8 seems to fix it. |
JaroslavTulach
requested review from
jdunkerley,
radeusgd and
GregoryTravis
as code owners
JaroslavTulach
commented
May 24, 2023
radeusgd
reviewed
May 24, 2023
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/TypeOfNode.java
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
May 24, 2023
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/TypeOfNode.java
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
May 24, 2023
There was a problem hiding this comment.
That enum dispatch pattern looks so much cleaner than the guards that we have before which kind of grew over time to be a bit messy and it was pretty hard to see if the condition of being disjunctive was even satisfied. The new code is so much easier to understand! 🎉
Just 2 small questions/suggestions above.
GregoryTravis
approved these changes
May 24, 2023
JaroslavTulach
force-pushed
the
wip/jtulach/UniqueSpecialization_6682
branch
from
ca1b79a
to
f32e2ba
Compare
hubertp
approved these changes
May 24, 2023
|
Jaroslav Tulach reports a new STANDUP for yesterday (2023-05-24): Progress: - robustness via enum dispatch pattern: #6819
Next Day: Bugfixing
|
Procrat
added a commit
that referenced
this pull request
May 26, 2023
* develop: Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771)
Procrat
added a commit
that referenced
this pull request
May 30, 2023
…le-6756-6804 * develop: (22 commits) Coalesce graph editor view invalidations (#6786) Append warnings extracted before tail call execution (#6849) Detect and override hooks of the same kind (#6842) Dynamic app resampling and better performance measurements. (#6595) Show spinner when opening/creating a project, take #2 (#6827) Infrastructure for testing inter project imports and exports (#6840) Only initialise visualisation chooser if it is used. (#6758) Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771) Update GraalVM to 22.3.1 JDK17 (#6750) Import/export syntax error have more specific messages (#6808) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Many of our specializations have complicated guards. They accept one alternative, but try to avoid others with negative checks. It is messy and problematic to keep consistency when expanding the guards. This PR proposes enum dispatch pattern instead. The algorithm to select a specialization is encoded in
findmethod - whatever gets selected is the right@Specialization. No need for negative guards.Since a86fd22 the check of
types.hasTypeis performed and if not, all the other operations are delegated toWithoutTypenode. That node can safely assumevaluedoesn't have a type.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,