Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and override hooks of the same kind #6842

Merged
merged 1 commit into from
May 29, 2023

Conversation

hubertp
Copy link
Contributor

@hubertp hubertp commented May 25, 2023

Pull Request Description

This change ensures that we can have at most one hook of the same action during shutdown.
Verified the change on a real project.

Closes #6767.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

This change ensures that we can have at most one hook of the same action
during shutdown.

Closes #6767.
@hubertp hubertp added the CI: No changelog needed Do not require a changelog entry for this PR. label May 25, 2023
@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label May 29, 2023
@mergify mergify bot merged commit 86432b5 into develop May 29, 2023
@mergify mergify bot deleted the wip/hubert/6767-multiple-renamings branch May 29, 2023 07:25
Procrat added a commit that referenced this pull request May 30, 2023
…le-6756-6804

* develop: (22 commits)
  Coalesce graph editor view invalidations (#6786)
  Append warnings extracted before tail call execution (#6849)
  Detect and override hooks of the same kind (#6842)
  Dynamic app resampling and better performance measurements. (#6595)
  Show spinner when opening/creating a project, take #2 (#6827)
  Infrastructure for testing inter project imports and exports (#6840)
  Only initialise visualisation chooser if it is used. (#6758)
  Allow casting a Mixed column into a concrete type (#6777)
  Stop graph editing when in full-screen visualization mode (#6844)
  Handle `show-dashboard` event (#6837)
  Fix some dashboard issues (#6668)
  Fix JWT leak (#6815)
  Fix "set username" screen (#6824)
  Fallback to opened date when ordering projects (#6814)
  Various test improvements to increase coverage and speed things up (#6820)
  do not activate nested dropdowns together (#6830)
  Clearly select single specialization with enum dispatch pattern (#6819)
  Prevent incorrect application of list widget on incompatible expressions (#6771)
  Update GraalVM to 22.3.1 JDK17 (#6750)
  Import/export syntax error have more specific messages (#6808)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming the project twice (or more) in the same project session leads to inconsistencies
3 participants