-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various test improvements to increase coverage and speed things up #6820
Conversation
There are strange errors like:
Very strange given we only change ascription (which is ignored) and unit tests (which are unrelated). |
This is a global problem with our CI now. Try to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The std-lib part of the changes looks good (I didn't check the rest).
I'm really glad that the runtime type checking is allowing us to catch errors in the type signatures 🎉
Jaroslav Tulach reports a new STANDUP for yesterday (2023-05-25): Progress: - Test coverage and speed up PR merged: #6820 Next Day: Bookclubs, bugfixing, ascribed types
|
* develop: Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771)
…le-6756-6804 * develop: (22 commits) Coalesce graph editor view invalidations (#6786) Append warnings extracted before tail call execution (#6849) Detect and override hooks of the same kind (#6842) Dynamic app resampling and better performance measurements. (#6595) Show spinner when opening/creating a project, take #2 (#6827) Infrastructure for testing inter project imports and exports (#6840) Only initialise visualisation chooser if it is used. (#6758) Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771) Update GraalVM to 22.3.1 JDK17 (#6750) Import/export syntax error have more specific messages (#6808) ...
Pull Request Description
This PR fixes some typing problems in
distribution
, speedsMetaIsATest
to 20s (previously 80s) by caching the computed values inValuesGenerator
and makes sure there are "polyglot variants" of tests checking the behavior ofMeta
andTypeOf
on JavaScript & other values.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,