Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various test improvements to increase coverage and speed things up #6820

Merged
merged 7 commits into from
May 25, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented May 24, 2023

Pull Request Description

This PR fixes some typing problems in distribution, speeds MetaIsATest to 20s (previously 80s) by caching the computed values in ValuesGenerator and makes sure there are "polyglot variants" of tests checking the behavior of Meta and TypeOf on JavaScript & other values.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. labels May 24, 2023
@JaroslavTulach JaroslavTulach self-assigned this May 24, 2023
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented May 24, 2023

There are strange errors like:

  - [FAILED] should send Get request using fetch [99ms]
Reason: An unexpected dataflow error ((Request_Error.Error 'IllegalArgumentException' Nothing)) 
has been matched (at /runner/_work/enso/enso/test/Tests/src/Network/Http_Spec.enso:57:13-53).

Very strange given we only change ascription (which is ignored) and unit tests (which are unrelated).

@Akirathan
Copy link
Member

There are strange errors like:

  - [FAILED] should send Get request using fetch [99ms]
Reason: An unexpected dataflow error ((Request_Error.Error 'IllegalArgumentException' Nothing)) 
has been matched (at /runner/_work/enso/enso/test/Tests/src/Network/Http_Spec.enso:57:13-53).

Very strange given we only change ascription (which is ignored) and unit tests (which are unrelated).

This is a global problem with our CI now. Try to add CI: Clean build required label and restart the job. The problem seems to be related to the recent GraalVM upgrade

@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label May 24, 2023
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The std-lib part of the changes looks good (I didn't check the rest).

I'm really glad that the runtime type checking is allowing us to catch errors in the type signatures 🎉

@JaroslavTulach JaroslavTulach merged commit b33ae47 into develop May 25, 2023
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/TestFixes_6682 branch May 25, 2023 08:18
@enso-bot
Copy link

enso-bot bot commented May 26, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-05-25):

Progress: - Test coverage and speed up PR merged: #6820
- triage: #6841 (comment)
- some import/exports analysis
- Testing infra: #6840
- mess with imports: https://discord.com/channels/@me/948519891961544714/1111203653555081216
- Investigating .type issues: https://github.com/orgs/enso-org/discussions/6762#discussioncomment-5996400
- reported "local variable runtime check": #6848
- ascribed union types: fe89655
- working on tests/fixes for more complex signatures It should be finished by 2023-05-25.

Next Day: Bookclubs, bugfixing, ascribed types

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
GitHub
When I was discussion with @Frizi the issue #6715, we discovered several points about Language Server API to be discussed broader @4e6 @hubertp : What widgets needs to know The widgets need to know...

Procrat added a commit that referenced this pull request May 26, 2023
* develop:
  Allow casting a Mixed column into a concrete type (#6777)
  Stop graph editing when in full-screen visualization mode (#6844)
  Handle `show-dashboard` event (#6837)
  Fix some dashboard issues (#6668)
  Fix JWT leak (#6815)
  Fix "set username" screen (#6824)
  Fallback to opened date when ordering projects (#6814)
  Various test improvements to increase coverage and speed things up (#6820)
  do not activate nested dropdowns together (#6830)
  Clearly select single specialization with enum dispatch pattern (#6819)
  Prevent incorrect application of list widget on incompatible expressions (#6771)
Procrat added a commit that referenced this pull request May 30, 2023
…le-6756-6804

* develop: (22 commits)
  Coalesce graph editor view invalidations (#6786)
  Append warnings extracted before tail call execution (#6849)
  Detect and override hooks of the same kind (#6842)
  Dynamic app resampling and better performance measurements. (#6595)
  Show spinner when opening/creating a project, take #2 (#6827)
  Infrastructure for testing inter project imports and exports (#6840)
  Only initialise visualisation chooser if it is used. (#6758)
  Allow casting a Mixed column into a concrete type (#6777)
  Stop graph editing when in full-screen visualization mode (#6844)
  Handle `show-dashboard` event (#6837)
  Fix some dashboard issues (#6668)
  Fix JWT leak (#6815)
  Fix "set username" screen (#6824)
  Fallback to opened date when ordering projects (#6814)
  Various test improvements to increase coverage and speed things up (#6820)
  do not activate nested dropdowns together (#6830)
  Clearly select single specialization with enum dispatch pattern (#6819)
  Prevent incorrect application of list widget on incompatible expressions (#6771)
  Update GraalVM to 22.3.1 JDK17 (#6750)
  Import/export syntax error have more specific messages (#6808)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants