Fix atom types in dropdowns. #7670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b218697.
vitvakatu
requested review from
MichaelMauderer,
farmaazon,
kazcw,
Frizi,
mwu-tow and
JaroslavTulach
as code owners
JaroslavTulach
approved these changes
Aug 29, 2023
Co-authored-by: Jaroslav Tulach <jaroslav.tulach@enso.org>
farmaazon
approved these changes
Aug 30, 2023
app/gui/view/src/project.rs
Outdated
| @@ -795,7 +799,7 @@ impl application::View for View { | |||
| (Press, "", "cmd alt p", "toggle_component_browser_private_entries_visibility"), | |||
| (Press, "", "cmd s", "save_project_snapshot"), | |||
| (Press, "", "cmd shift r", "restore_project_snapshot"), | |||
| (Press, "", "cmd z", "undo"), | |||
| // (Press, "", "cmd z", "undo"), | |||
There was a problem hiding this comment.
Commented shortcut. Quite important, I'd say.
There was a problem hiding this comment.
Oh, good catch. It was left after debugging.
|
QA: 🍏 The debug shortcut didn't work for me. The reported cases seem to work, I'm only surprised "Boolean.True" is not imported? |
Yep, there was an issue tracked in #7674. Fixing that issue should (I think) fix the booleans automatically. If not, we will handle it in a separate task. As for debug shortcut, it only works with the CB being opened (not the best UX), perhaps this is the reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #7468
The fix is pretty simple: we reuse the existing functionality for importing stuff and generating expressions. It fixes issues with
NothingorReport_Unmatchedtypes.Kapture.2023-08-28.at.14.26.04.mp4
While debugging, I found it easier to work with a suggestion database when exported to some external format. Hence, I implemented serde serialization support for database entries and also a new debug shortcut ctrl+shift+u to dump all entries to the console.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.