Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially fix further std-benchmarks issues #9541

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Potentially fix further std-benchmarks issues #9541

merged 1 commit into from
Mar 27, 2024

Conversation

hubertp
Copy link
Contributor

@hubertp hubertp commented Mar 26, 2024

I'm unable to reproduce so this is a wild guess that we are missing the dependency on the classpath.

@hubertp
Potentially fix further std-benchmarks issues
ee32d34 
I'm unable to reproduce so this is a wild guess that we are missing the
dependency on the classpath.
@hubertp hubertp added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 26, 2024
@hubertp
Copy link
Contributor Author

hubertp commented Mar 27, 2024

Turns out it worked. See #9309

Akirathan
Akirathan approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this can really solve the issue, since it at least brings one more correct dependency on the class-path. Nice observation.

@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label Mar 27, 2024
@mergify mergify bot merged commit 5d7cbcc into develop Mar 27, 2024
42 of 43 checks passed
@mergify mergify bot deleted the wip/hubert/mac-build-issues branch March 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hubertp @Akirathan