-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix the runner's memory check #9309
Conversation
if self.config.build_engine_package() { | ||
tasks.push("engine-runner/assembly"); | ||
tasks.push("buildEngineDistribution"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildEngineDistribution
is a command required for many other commands (for example, dry-run benchmarks and Enso tests). I believe that, at least on Linux, this command is usually run as the very first command. We should ensure that this is run also on other architectures. If not, we may bump into weird dependency issues. Please ensure that self.config.build_engine_package
is set on MacOS and Windows as well.
I'm unable to reproduce so this is a wild guess that we are missing the dependency on the classpath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright
Pull Request Description
The
sysinfo
crate returns now bytes, not kilobytes.This was changed in
sysinfo
's0.26.0
version. I have missed this change previously while bumping CI code dependencies.The effects were not drastic as both fast and slow paths were meant to be generally equivalent.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.