Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix the runner's memory check #9309

Merged
merged 20 commits into from
Mar 28, 2024
Merged

[CI] Fix the runner's memory check #9309

merged 20 commits into from
Mar 28, 2024

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Mar 6, 2024

Pull Request Description

The sysinfo crate returns now bytes, not kilobytes.

This was changed in sysinfo's 0.26.0 version. I have missed this change previously while bumping CI code dependencies.

The effects were not drastic as both fast and slow paths were meant to be generally equivalent.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow self-assigned this Mar 7, 2024
@mwu-tow mwu-tow added the CI: Keep up to date Automatically update this PR to the latest develop. label Mar 12, 2024
@mwu-tow mwu-tow removed the CI: Keep up to date Automatically update this PR to the latest develop. label Mar 13, 2024
@mwu-tow mwu-tow added CI: No changelog needed Do not require a changelog entry for this PR. CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Mar 15, 2024
Comment on lines +342 to +345
if self.config.build_engine_package() {
tasks.push("engine-runner/assembly");
tasks.push("buildEngineDistribution");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildEngineDistribution is a command required for many other commands (for example, dry-run benchmarks and Enso tests). I believe that, at least on Linux, this command is usually run as the very first command. We should ensure that this is run also on other architectures. If not, we may bump into weird dependency issues. Please ensure that self.config.build_engine_package is set on MacOS and Windows as well.

@mwu-tow mwu-tow marked this pull request as ready for review March 27, 2024 00:50
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@mwu-tow mwu-tow added the CI: Ready to merge This PR is eligible for automatic merge label Mar 28, 2024
@mergify mergify bot merged commit 7eafc5d into develop Mar 28, 2024
40 of 42 checks passed
@mergify mergify bot deleted the wip/mwu/memory-check-fix branch March 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants