Reverse order of stack frames and test the result #9954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
commented
May 14, 2024
| fullStackReversed.stream() | ||
| .dropWhile(f -> !LanguageInfo.ID.equals(fnLangId.apply(f))) | ||
| .toList()); | ||
| Collections.reverse(dropInitJava); |
There was a problem hiding this comment.
This is the changed line. The rest is just a refactoring to make things testable.
Akirathan
approved these changes
May 14, 2024
JaroslavTulach
added
the
CI: Ready to merge
JaroslavTulach
added
the
CI: Keep up to date
JaroslavTulach
added
the
CI: Clean build required
JaroslavTulach
requested review from
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
somebody1234
approved these changes
May 15, 2024
MrFlashAccount
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #9934 by reversing the order of
dropInitJavaframes.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,