-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/styles #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/styles #15
Conversation
refactordoc/items/argument_item.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an absolute import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are a number of problems with this PR currently and it is not ready for review (please note the in-progress label) sorry for the confusion.
# By itziakos # Via itziakos * origin/feature/styles: fix tests update the section methods start updading the section rendering methods better separate the items and thier parsing constructors from the renderers add a subpackage for renderers update tests minor cleanup minor cleanup rework class and function tests to old_style tests remove unused classes move code for old_styles to the styles module provide eaiser access to the Items and fix code factor out section refactoring functions to the sections module subclass namedtuple use the Item as a base class factor out Item
Conflicts: .travis.yml
@sjagoe, This PR is ready for review now. The main feature is the ability to fine tune the rendering behaviour thought defining new rendering The new components are:
Tests have been also updated. |
I'll try to look at it today. |
docs/source/old_style.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can use a better name. What is old
style? Is it what was used in refactordoc
? If so, call it that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is the style that refactordoc uses, but I want to discourage its use. I could call it something like simple
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed to legacy
This pr provides a major refactoring effort forv section doc (former refactor doc). the package layout has been rearranged into syles, sections, parsiing definition, renderers
implements #13