Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "super" calls in potentially buggy cases #1583

Merged
merged 7 commits into from
Apr 21, 2021
Merged

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Apr 21, 2021

This PR first fixes and then removes arguments from the super calls in various traitsui objects.

@rahulporuri rahulporuri added this to In progress in Enthought OSS Q2 2021 Apr 21, 2021
@rahulporuri rahulporuri changed the title [WIP] Update "super" calls in potentially buggy cases Fix "super" calls in potentially buggy cases Apr 21, 2021
traitsui/editor.py Outdated Show resolved Hide resolved
traitsui/editors/range_editor.py Outdated Show resolved Hide resolved
traitsui/editors/range_editor.py Outdated Show resolved Hide resolved
traitsui/group.py Outdated Show resolved Hide resolved
traitsui/handler.py Outdated Show resolved Hide resolved
traitsui/include.py Outdated Show resolved Hide resolved
traitsui/qt4/list_str_editor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 1179859 into master Apr 21, 2021
@rahulporuri rahulporuri deleted the rahulporuri-patch-1 branch April 21, 2021 13:41
@rahulporuri rahulporuri moved this from In progress to Done in Enthought OSS Q2 2021 Apr 21, 2021
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
@rahulporuri rahulporuri moved this from Done to Sprint 2 : 19 April - 30 April 2021 in Enthought OSS Q2 2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q2 2021
  
Sprint 2 : 19 April - 30 April 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants