Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "super" usage in "traitsui.wx" #1588

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

rahulporuri
Copy link
Contributor

This PR updates the super usage in classes in traitsui.wx submodule. The update was done using automated regex-based search and replace. After the changes were made, each changes was individually checked to ensure that we were calling super with the right arguments before.

Ref enthought/traits#1280. Also see related #1587

This commit updates the super usage in classes in traitsui.wx submodule.
The update was done using automated regex-based search and replace.
After the changes were made, each changes was individually checked to
ensure that we were calling super with the right arguments before
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 028df84 into master Apr 23, 2021
@rahulporuri rahulporuri deleted the cln/update-super-usage-wx branch April 23, 2021 15:05
@rahulporuri rahulporuri moved this from In progress to Done in Enthought OSS Q2 2021 Apr 23, 2021
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
@rahulporuri rahulporuri moved this from Done to Sprint 2 : 19 April - 30 April 2021 in Enthought OSS Q2 2021 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q2 2021
  
Sprint 2 : 19 April - 30 April 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants