Update "super" usage in misc traitsui code #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit, together with other earlier PRs, update super usage in the traitsui codebase. This commit, like other commits, updated super using automated regex-based search and replace. After the changes were made, each call was checked to ensure that super was being called with the correct arguments.
rahulporuri
commented
Apr 23, 2021
| @@ -65,7 +65,7 @@ class ThreadDemo(HasTraits): | |||
| ) | |||
|
|
|||
| def __init__(self, **traits): | |||
| super(HasTraits, self).__init__(**traits) | |||
There was a problem hiding this comment.
this should have been ThreadDemo and included in #1583 but i missed it earlier.
rahulporuri
pushed a commit
that referenced
this pull request
Apr 26, 2021
rahulporuri
pushed a commit
that referenced
this pull request
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, together with #1587 and #1588, update
superusage in the traitsui codebase. This PR, like other PRs, updatedsuperusing automated regex-based search and replace. After the changes were made, each call was checked to ensure thatsuperwas being called with the correct arguments.Ref enthought/traits#1280.