Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "super" usage in "traitsui.qt4" #1587

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

rahulporuri
Copy link
Contributor

This PR updates super usage in the traitsui.qt4 submodule. The updates were done using automated regex-based search and replace. After the updates were done, we checked each of the changes to ensure that we were calling super with the right arguments before.

Ref enthought/traits#1280

This commit updates super usage in the traitsui.qt4 submodule.
The updates were done using automated regex-based search and replace.
After the updates were done, we checked each of the chanegs to ensure
that we were calling super with the right arguments before
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit c4b4d12 into master Apr 23, 2021
@rahulporuri rahulporuri deleted the cln/update-super-usage-qt branch April 23, 2021 15:04
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Together with #1583, #1587 , #1588 and #1589 , this PR fixes #1167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants