Chore: Refactor Options #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
options are not generally applicable - let's move to provider-specific options model, and remove some redundancies
required for merge
\d metacharacter not supported
the-avid-engineer
added
the
diff:refactor:break
allowing configuration of different TSnapshots using Configure and ConfigureAll
…arameter not being used also, if we ever switch to record, it won't allow the connection strings to be exposed accidentally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options really depend on each implementation, and it is easier to just have all configuration one one object instead of splitting shared pieces into a shared options object and injecting the rest of the options manually. This change addresses that.
In addition, it adds a new beta deployment procedure so that changes can be tested without having to merge to the main branch!