Refactor: Better Transaction Subscriber #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduces a concept of ITransactionProcess which handles the logic of processing a transaction, and does nothing else. allows the queueing logic to be abstracted away and code coverage the be better
the-avid-engineer
added
diff:add
generate new license key and store as a secret
manually tagging no more, just create a release and choose a tag which is a version number
|
I don't think the complexity can be reduced.. just going to ignore that it's "too high" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a concept of
ITransactionProcessorwhich handles the logic of processing a transaction, and does nothing else. The queueing logic can be split apart and code coverage improves slightly by reducing the number of methods whose coverage needs to be ignored.