Update the icons list for the last version 5.4.1 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
leandrosimoes
commented
Oct 23, 2018
leandrosimoes
commented
- Update the icons list for the last version 5.4.1
- Created a IconTypes object that contains the font families so you can pass through the FontAwesome component properties (Why and How: README)
- Created a parseIconName function so you can parse the font awesome classes to a valid name to use in this component. (Why and How: README)
- Updated the README with the new features
|
@jgcmarins I just fix a missing var. Sorry about that. |
|
+1 |
|
Any chance this can be merged? |
jgcmarins
reviewed
Nov 7, 2018
FontAwesomeIcons.js
Outdated
| } | ||
|
|
||
| Object.keys(Icons).forEach((iconKey) => { |
There was a problem hiding this comment.
@leandrosimoes why removing this?
There was a problem hiding this comment.
I just removed by mistake, I'm so sorry about that! I just revert this lines and made another commit. Thanks for the review!
Previous example didn't align with actual code. Probably just out of date.
Added all tachometer variants of 5.5 pro. Added external link icon.
Updated parseIconName example for accuracy
jgcmarins
reviewed
Nov 8, 2018
.vscode/launch.json
Outdated
| @@ -0,0 +1,22 @@ | |||
| { | |||
There was a problem hiding this comment.
can we remove this file?
add .vscode to .gitignore
There was a problem hiding this comment.
Sure, I just put this file for run the tests with F5.
There was a problem hiding this comment.
I just removed the file and sent another commit. Tks.
sibelius
approved these changes
Nov 8, 2018
|
Anyway you can make a new build version so this is available on npm? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.