Skip to content

Finalize #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Finalize #2

wants to merge 4 commits into from

Conversation

enum-class
Copy link
Owner

No description provided.

enum-class and others added 3 commits October 1, 2025 16:52
@enum-class
Support LLVM raw profile versions 8, 9, and 10
3dc1fe6 
This change enables compatibility for measuring code coverage
with Clang versions 14 through 20 by supporting their
respective raw profile formats.

Signed-off-by: Saman Dehghan <samaan.dehghan@gmail.com>
@enum-class
Merge branch 'xen-project:master' into finalize
da4b91e
@enum-class
revert some unnecessary changes
58af111
@whentojump
Copy link
Collaborator

whentojump commented Oct 6, 2025 •
edited
Loading

Let me list some to-do's

  • LLVM v14-trunk (inclusive) line coverage. One thing to figure out is are those char * changes really necessary?
  • Squash into one commit with proper message and Signed-off-by
  • Do a careful review of #ifdef's in this patch comparing to LLVM change history
  • (Potentially as a separate follow-up) LLVM v11-v13 (inclusive) line coverage.
  • (Potentially as a separate follow-up) LLVM v18-trunk (inclusive) MC/DC.
  • (Potentially as a separate follow-up) Documentation and misc.

whentojump
whentojump reviewed Oct 7, 2025
View reviewed changes
xen/common/coverage/llvm.c
#define LLVM_PROFILE_VERSION 8
#define LLVM_PROFILE_NUM_KINDS 2
#else
#error "Unsupported Clang version"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe be more specific e.g. "LLVM coverage selected but an unsupported clang version is used" so that people don't wrongly think Clang <14 is not supported at all even w/o coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whentojump whentojump whentojump left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enum-class @whentojump