Chore make the release process simply #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiliFaroEnv0
added
pending final review
work in progress
and removed
work in progress
pending final review
labels
avnerenv0
reviewed
Feb 24, 2022
| name: Update generated docs | ||
| run: ./generate-docs.sh | ||
| - | ||
| name: Commit changes |
There was a problem hiding this comment.
will this always create a commit?
can we do it only when the docs have changed ?
There was a problem hiding this comment.
It will Only commit IF it has something to commit 😄
README.md
Outdated
|
|
||
| 1. Create and push a tag **locally**, in semver format - `git tag v0.0.9 && git push origin --tags` | ||
| 2. New release with binaries **will be automatically generated** by the GitHub action defined in `.github/workflows/release.yml`. | ||
| 2. The Registry will automatically pick up on the new version. If the registry says the release doesn't have any binaries, check the result of the `release` Github action. You might need to [Resync](https://registry.terraform.io/providers/env0/env0/latest/settings?pollNotifications=true) the registry after the action finishes. |
There was a problem hiding this comment.
I thought the whole point of this task was so that we don't have to rely on manual re-sync, because only I have that button.
There was a problem hiding this comment.
.github/workflows/ci.yml
Outdated
| @@ -13,7 +13,7 @@ jobs: | |||
| - name: Install Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.16 # please change also in `release.yml` and `go.mod` | |||
| go-version: 1.16 # please change also in `release.yml`,`update-generated-docs.yml` and `go.mod` | |||
There was a problem hiding this comment.
BTW keeping this as a Github Secret would be an easy way to share a single version between all the files.
avnerenv0
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
Solution
Add auto-generate for docs
update README on of you need to release properly 😄
removed unused "release drafter"