Added SVG resource file for Icon #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SebaDro sir please review it. |
|
@SebaDro @arvindnegi1 @bpross-52n can you please review it before it gets superseded? |
asaikarthikeya
requested review from
asaikarthikeya
and removed request for
SebaDro
asaikarthikeya
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
LGTM, Valid point. I have tested this in a Tablet. There are few other areas were ic_drive_eta_black_24dp is still used. You can consider to change them also. Please rebase onto develop. Thankyou for the PR @Akash-Ramjyothi ;)
|
@asaikarthikeya I have successfully rebased it onto develop. Thank you for approving. Can you please Merge this PR? |
|
Will be closed due to the same reason as #898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #701
Description:
Replaced the existing
PNG (Portable Network Graphics)resource file with an existingSVG (Scalable Vector Graphics)resource file without altering the Texture to improve scalability across various screens.Link for currently used PNG:
https://github.com/enviroCar/enviroCar-app/blob/master/org.envirocar.app/res/drawable-hdpi/ic_drive_eta_black_24dp.png
Link for SVG:
https://github.com/enviroCar/enviroCar-app/blob/master/org.envirocar.app/res/drawable/ic_directions_car_black_24dp.xml