Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating libraries. #743

Merged
merged 30 commits into from
Jun 15, 2021
Merged

Updating libraries. #743

merged 30 commits into from
Jun 15, 2021

Conversation

asaikarthikeya
Copy link
Member

@asaikarthikeya asaikarthikeya commented Jun 8, 2021

Updated the libraries to their latest stable versions. Tested the functionality of the app in Apk 29, Apk 30. Everything works fine.

@asaikarthikeya asaikarthikeya changed the base branch from develop to gsoc2021 June 9, 2021 13:08
@asaikarthikeya
Copy link
Member Author

asaikarthikeya commented Jun 9, 2021

@bpross-52n @SebaDro Please review the changes sir. Thank you.

@SebaDro
Copy link
Contributor

SebaDro commented Jun 14, 2021

It seems upgrading ch.acra:acra-core to 5.8.3 causes a build failure:

enviroCar-app\org.envirocar.app\src\org\envirocar\app\BaseApplication.java:63: error: cannot find symbol
@acracore(buildConfigClass = BuildConfig.class, reportSenderFactoryClasses = ACRASenderFactory.class)
^
symbol: method reportSenderFactoryClasses()
location: @interface AcraCore
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

@asaikarthikeya Could you fix this before I will merge your pull request?

@asaikarthikeya
Copy link
Member Author

asaikarthikeya commented Jun 14, 2021

It seems upgrading ch.acra:acra-core to 5.8.3 causes a build failure:

enviroCar-app\org.envirocar.app\src\org\envirocar\app\BaseApplication.java:63: error: cannot find symbol
@acracore(buildConfigClass = BuildConfig.class, reportSenderFactoryClasses = ACRASenderFactory.class)
^
symbol: method reportSenderFactoryClasses()
location: @interface AcraCore
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

@asaikarthikeya Could you fix this before I will merge your pull request?

The version that i have used 5.8.3 was a very recent release( Released a week ago). I have update to a version which is most used. Could you check this with this version number?

@SebaDro SebaDro self-requested a review June 15, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants