Skip to content

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Apr 22, 2025

fixes #10

tested on my fork repo: https://github.com/liangyuanpeng/dynamic-modules-examples/actions/runs/14596083199/job/40942220617

the second commit just change the README and the CI time has been shortened from 5m30s to 5s.

image

@liangyuanpeng liangyuanpeng force-pushed the image_cache branch 2 times, most recently from 2aed123 to eb47ee0 Compare April 22, 2025 13:15
@liangyuanpeng liangyuanpeng marked this pull request as draft April 22, 2025 13:24
Signed-off-by: Lan <gcslyp@gmail.com>
@liangyuanpeng liangyuanpeng marked this pull request as ready for review April 22, 2025 13:33
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thank you so much

@mathetake
Copy link
Member

ah i think the current workflow is not working on PRs from forks - i will go ahead and merge this but i need to fix that in a separate pr

@mathetake mathetake merged commit 329f0f6 into envoyproxy:main Apr 22, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CI faster / enable build cache
2 participants