kafka: add support for list-offsets request #24375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-list-offsets
branch
from
64f55cd to
313ed78
Compare
|
/assign @mattklein123 |
adamkotwasinski
changed the title
mattklein123
approved these changes
Dec 6, 2022
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: add support for list-offsets request
Additional Description: When Kafka consumer starts getting records from upstream Kafka cluster, the first request it sends to upstream is actually asking for its position (this data is then used in following requests, updated as records are received). As the offset management is going to be left to proxy/Envoy we can send a trivial
0here, simplifying the code.Required for #24372
Risk Level: Low
Testing: unit tests, full integration stack with Fetch requets
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A