flow control: side stream flow control part 2 #35077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: tyxia <tyxia@google.com>
tyxia
commented
Jul 8, 2024
alyssawilk
reviewed
Jul 9, 2024
|
/wait-any |
Signed-off-by: tyxia <tyxia@google.com>
tyxia
commented
Jul 15, 2024
|
PTAL @yanavlasov |
Signed-off-by: tyxia <tyxia@google.com>
alyssawilk
reviewed
Jul 22, 2024
tyxia
added a commit
that referenced
this pull request
Jul 23, 2024
Commit Message: This PR is split from #35077. The change is specifically needed for ext_proc's observability mode where the stream is deferred closed upon filter destruction (i.e., stream outlives the filter object) Risk Level: Low, existing runtime guard and observability mode only Testing: e2e test and load test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <tyxia@google.com>
…control_2 Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: tyxia <tyxia@google.com>
alyssawilk
approved these changes
Jul 25, 2024
|
I just synced with @yanavlasov in offline discussion. He is ok with proceeding with this PR. Merging... |
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
Commit Message: This PR is split from envoyproxy#35077. The change is specifically needed for ext_proc's observability mode where the stream is deferred closed upon filter destruction (i.e., stream outlives the filter object) Risk Level: Low, existing runtime guard and observability mode only Testing: e2e test and load test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
- Deprecated and replaced the `DecoderFilterWatermarkCallbacks` that was introduced [PR](envoyproxy#25207) with `SidestreamWatermarkCallbacks` in this PR so that both encoder and decode filter callbacks can be registered - Implements sidestream push back on upstream Risk Level: Low, existing runtime guard Testing: integration test and unit test Docs Changes: N/A. a design doc in draft https://docs.google.com/document/d/1fwISI5wKQe6H3EOuaDLrAAgPU8Hq3KXaxJG0pm3vu-4/edit#heading=h.xgjl2srtytjt and will add it to envoy flow control doc in the end or at least when full flow control is approved. Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Commit Message: This PR is split from envoyproxy#35077. The change is specifically needed for ext_proc's observability mode where the stream is deferred closed upon filter destruction (i.e., stream outlives the filter object) Risk Level: Low, existing runtime guard and observability mode only Testing: e2e test and load test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
- Deprecated and replaced the `DecoderFilterWatermarkCallbacks` that was introduced [PR](envoyproxy#25207) with `SidestreamWatermarkCallbacks` in this PR so that both encoder and decode filter callbacks can be registered - Implements sidestream push back on upstream Risk Level: Low, existing runtime guard Testing: integration test and unit test Docs Changes: N/A. a design doc in draft https://docs.google.com/document/d/1fwISI5wKQe6H3EOuaDLrAAgPU8Hq3KXaxJG0pm3vu-4/edit#heading=h.xgjl2srtytjt and will add it to envoy flow control doc in the end or at least when full flow control is approved. Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecoderFilterWatermarkCallbacksthat was introduced PR withSidestreamWatermarkCallbacksin this PR so that both encoder and decode filter callbacks can be registeredRisk Level: Low, existing runtime guard
Testing: integration test and unit test
Docs Changes: N/A. a design doc in draft https://docs.google.com/document/d/1fwISI5wKQe6H3EOuaDLrAAgPU8Hq3KXaxJG0pm3vu-4/edit#heading=h.xgjl2srtytjt and will add it to envoy flow control doc in the end or at least when full flow control is approved.
Release Notes: N/A
Platform Specific Features: N/A