Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add API for Custom provider #1402

Merged
merged 3 commits into from
May 11, 2023
Merged

feat: Add API for Custom provider #1402

merged 3 commits into from
May 11, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 6, 2023

Relates to #1393

@arkodg
Add API for Custom provider
cc14f97 
Relates to envoyproxy#1393

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 6, 2023 00:01
@arkodg arkodg mentioned this pull request May 6, 2023
Open
5 tasks
@codecov
Copy link

codecov bot commented May 6, 2023 •
edited
Loading

Codecov Report

Merging #1402 (7ad5752) into main (b90946c) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   62.63%   62.31%   -0.32%     
==========================================
  Files          79       79              
  Lines       11116    11169      +53     
==========================================
- Hits         6962     6960       -2     
- Misses       3699     3753      +54     
- Partials      455      456       +1
Impacted Files Coverage Δ
api/config/v1alpha1/envoygateway_types.go 100.00% <ø> (ø)
api/config/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@qicz
Copy link
Member

qicz commented May 6, 2023

word spell error

@arkodg
lint
901a44e 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
kflynn
kflynn suggested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API content looks good to me – how 'bout some user-facing doc? 🙂

@arkodg
Copy link
Contributor Author

arkodg commented May 9, 2023 •
edited
Loading

The API content looks good to me – how 'bout some user-facing doc? 🙂

@kflynn should be here https://gateway.envoyproxy.io/latest/design/local-envoy-gateway.html
user facing docs are being tracked with #1393 and should be completed once the implementation is ready :)

Alice-Lilith
Alice-Lilith approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@Alice-Lilith Alice-Lilith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good to me

@zirain zirain merged commit 5f222eb into envoyproxy:main May 11, 2023
tanujd11 pushed a commit to tanujd11/gateway that referenced this pull request May 20, 2023
@arkodg @Xunzhuo @tanujd11
feat: Add API for Custom provider (envoyproxy#1402)
c2017b3 
* Add API for Custom provider

Relates to envoyproxy#1393

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
@arkodg arkodg deleted the custom-provider-api branch June 1, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflynn kflynn kflynn requested changes

@qicz qicz qicz approved these changes

@Alice-Lilith Alice-Lilith Alice-Lilith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arkodg @qicz @kflynn @Alice-Lilith @zirain @Xunzhuo