#72 simplify the jca versioning support #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjwills28 could you have a look at this PR ( I am hoping to include it in the next release ) |
rjwills28
approved these changes
Mar 20, 2024
src/core/gov/aps/jca/Version.java
Outdated
| * @return version number | ||
| */ | ||
| private String getVersion() { | ||
| return version; |
There was a problem hiding this comment.
Minor formatting inconsistency - this line and the following should be spaced not tabbed.
src/core/gov/aps/jca/JCALibrary.java
Outdated
| @@ -125,12 +138,16 @@ protected JCALibrary() { | |||
|
|
|||
| } | |||
|
|
|||
| public String getVersion() { | |||
| return versionProperties.getProperty("jca.version"); | |||
There was a problem hiding this comment.
Minor formatting inconsistency - this line and the following should be spaced not tabbed.
|
Thanks |
|
@rjwills28 I think I have fixed the formatting |
|
Hi @shroffk - is there any update on the new release of JCA? Thanks. |
|
The 2.4.10 release is done. I will not do a complete epics core Java release for now though. |
|
@shroffk - thanks for taking care of that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the manually managed version numbers in the CAJContext and CAJServerContext.
Simplified the Version class to only support an automatically managed version string. Could not find any usage of the old Major, Minor,... fields. I have marked them as deprecated in case someone is still using Version class directly in their code.