-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Numpy and Cython for Python 3.10 and 3.11 builds #152
Update Numpy and Cython for Python 3.10 and 3.11 builds #152
Conversation
With reference to the discussion starting here #145 (comment) I think some changes and additions will be necessary.
This would clearly state that numpy 1.7 is the minimum support by P4P. eg. when building against numpy 1.10.0, the eg. when building against numpy 2.0.0, the As mentioned at the bottom at some point it would be good to test the backwards compatibility at the end of a 2.x build by rolling back numpy and re-running the unit tests. I don't see this as a blocker for this PR. |
47ef0b1
to
1b0e5e8
Compare
It seems that removing the condition for this breaks the builds... |
1b0e5e8
to
d99a8df
Compare
d99a8df
to
47e04e5
Compare
Also |
Replacing |
A negative Even with these changes, I am still seeing a couple of build failures. One appears to be a bug in numpy 2.0.1 building with MSVC. The Linux py3.9 manylinux2010_x86_64 job does not find a numpy 2.0.1. Indeed there is no manylinux wheel for 3.9
The OSX 3.7 build fails with what I hope is a caching glitch.
|
|
I have a fork with a branch looking at updating supported versions and images (including arguing for the removal of Python 2.7 and 3.5 support), and using |
@mdavidsaver are you happy to merge this PR in so we can make another beta release to allow people to test their builds with Python 3.10 and 3.11? We can then merge in the Numpy fix for Windows builds in another PR? |
6a255fa
to
03a1308
Compare
I made another iteration to pin the windows builds to numpy 1.x until the |
@mdavidsaver Just to confirm, do you want to wait for a Numpy release that fixes that particular issue, or are you happy if we try and work around it? |
At this point the numpy fix for MSVC is merged, but not released. I have re-triggered all jobs to see if they still pass. If so, then I think I am ok with disabling/ignoring the one failing job until the next numpy release. |
Merged as of b1052f4 . |
fyi. It looks like this fix appears in numpy >= |
This PR sets the wheel builds for Python 3.10 and 3.11 to use Numpy 2.0.1