Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

200317 no defs in release #156

Conversation

tboegi
Copy link
Contributor

@tboegi tboegi commented Mar 17, 2020

No description provided.

To get the make process working with travis, comment out line like
SUPPORT=/path/to/support

Same for EPICS_BASE, ASYN
@tboegi tboegi force-pushed the 200317-no-defs-in-RELEASE branch from 1d76a6c to c0f5ead Compare March 17, 2020 10:41
@kmpeters
Copy link
Member

The dummy definitions were added because empty definitions caused other problem. I'm reluctant to comment them out, since they are required.

@tboegi tboegi closed this Mar 17, 2020
@tboegi
Copy link
Contributor Author

tboegi commented Mar 17, 2020

I don't know which problems the dummy definitions cause -
so I'll close the PR

@ralphlange
Copy link
Member

Setting SUPPORT is a valid way to avoid repeating the support location over and over again in manually managed RELEASE files.

When used in combination with an included RELEASE.local file that contains generated full paths (like when using the ci-scripts module), a SUPPORT=/foo/bar definition will not be overwritten by the generated settings.
To the test in Base, SUPPORT=/foo/bar looks like another definition of a dependency module. If a different module in the build happens to specify SUPPORT=/bar/foo, the test will bark, even if both definitions are not used.

Module definitions are sometimes used to activate specific parts of Makefiles that are only needed when that dependency module is defined. (Frequently used for dependencies that are not mandatory.) In such cases, not defining a module may have unwanted side effects.

@ralphlange
Copy link
Member

Starting with commit epics-base/ci-scripts@aee11f2, the ci-scripts modules overwrites the RELEASE file in dependency modules, which should get rid of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants