send_mess() uses 'const char *' #2
Conversation
|
@tboegi, did you mean for removal of |
|
@kmpeters Thanks for the review- |
The 3rd parameter in send_mess(), "name" can and should be a 'const char *' instead of just 'char *'. Modern compilers complain here, so that the signature now gets the const. While here, change static constant strings, like static const char *oms_axis[] This is a minimal part of a series from Dirk Zimoch, more warnings can be removed here and there.
|
@kmpeters : |
|
@tboegi, I'm still confused. Should the changes to lines 844, 849, 850, 852, 853, and 894 of drvOmsPC68.cc be a part of this commit? It looks like they might resolve related, but slightly different warning messages that may be a part of the future pull-requests you mentioned. |
tboegi
force-pushed
the
190920_send_mess_uses_const_char
branch
from
1a72e57 to
261383e
Compare
|
Sorry for the confusion, |
|
This looks good. |
The 3rd parameter in send_mess(), "name" can and should
be a 'const char *' instead of just 'char *'.
Modern compilers complain here, so that the signature now
gets the const.
This is a minimal part of a series from Dirk Zimoch,
more warnings can be removed here and there.