Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent policy on namespace #81

Closed
athowes opened this issue Jun 6, 2024 · 3 comments
Closed

Consistent policy on namespace #81

athowes opened this issue Jun 6, 2024 · 3 comments
Labels
infrastructure medium Nice to have for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Jun 6, 2024

we need to do something about our namespace. Are we:

  1. Not using the namespace nad only using package::function
  2. Using @importFrom in the roxygen
  3. Both all the time
    1. and then sometimes 1. for uncommon functions

Originally posted by @seabbs in #70 (comment)

Based on call with @seabbs, I currently prefer importing all functions from currently used packages (data.table, ggplot2, maybe brms) and then using :: for other things. Perhaps this is only because I've never used the roxygen2 version. Also if a user copy pastes the function out of their R console it won't have the roxygen2 right?

@seabbs
Copy link
Contributor

seabbs commented Jun 6, 2024

I think it would be unusual to use a mix of namespace and ::. If using the namespace at all I think we want everything in it but we can also use :: as you say

@athowes athowes added the medium Nice to have for next release label Aug 8, 2024
@athowes
Copy link
Collaborator Author

athowes commented Sep 18, 2024

think it would be unusual to use a mix of namespace and ::. If using the namespace at all I think we want everything in it but we can also use :: as you say

Note that this is different to where we ended up I think.

This should be closed by #329.

@athowes
Copy link
Collaborator Author

athowes commented Sep 18, 2024

Closed by #329.

@athowes athowes closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure medium Nice to have for next release
Projects
None yet
Development

No branches or pull requests

2 participants