-
Notifications
You must be signed in to change notification settings - Fork 1
Support delete item #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 57 additions & 51 deletions
108
...izely.Graph.Source.Sdk/Optimizely.Graph.Source.Sdk/Repositories/IGraphSourceRepository.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,57 @@ | ||
using Optimizely.Graph.Source.Sdk.SourceConfiguration; | ||
using System.Linq.Expressions; | ||
|
||
namespace Optimizely.Graph.Source.Sdk.Repositories | ||
{ | ||
public interface IGraphSourceRepository | ||
{ | ||
/// <summary> | ||
/// Adds language preference to SourceConfigurationModel. | ||
/// </summary> | ||
/// <param name="language"></param> | ||
void AddLanguage(string language); | ||
|
||
void ConfigureLink<T, U>(string name, Expression<Func<T, object>> from, Expression<Func<U, object>> to); | ||
|
||
/// <summary> | ||
/// Configures Content Types within the SourceConfigurationModel. | ||
/// </summary> | ||
/// <typeparam name="T">Generic content type.</typeparam> | ||
/// <returns></returns> | ||
SourceConfigurationModel<T> ConfigureContentType<T>() where T : class, new(); | ||
|
||
/// <summary> | ||
/// Configures Content Property Types within the SourceConfigurationModel. | ||
/// </summary> | ||
/// <typeparam name="T">Generic property type.</typeparam> | ||
/// <returns></returns> | ||
SourceConfigurationModel<T> ConfigurePropertyType<T>() where T : class, new(); | ||
|
||
/// <summary> | ||
/// Saves Content Types set in the SourceConfigurationModel to the Content Graph api. | ||
/// </summary> | ||
/// <returns></returns> | ||
Task<string> SaveTypesAsync(); | ||
|
||
/// <summary> | ||
/// Saves dynamic content sent in data array to the Content Graph api. | ||
/// </summary> | ||
/// <typeparam name="T"></typeparam> | ||
/// <param name="generateId">Id associated with content.</param> | ||
/// <param name="data">Dynamic data being saved to Content Graph.</param> | ||
/// <returns></returns> | ||
Task<string> SaveContentAsync<T>(Func<T, string> generateId, string language, params T[] data) where T : class, new(); | ||
|
||
/// <summary> | ||
/// Removes content previously stored by source. | ||
/// </summary> | ||
/// <returns></returns> | ||
Task<string> DeleteContentAsync(); | ||
} | ||
} | ||
using Optimizely.Graph.Source.Sdk.SourceConfiguration; | ||
using System.Linq.Expressions; | ||
|
||
namespace Optimizely.Graph.Source.Sdk.Repositories | ||
{ | ||
public interface IGraphSourceRepository | ||
{ | ||
/// <summary> | ||
/// Adds language preference to SourceConfigurationModel. | ||
/// </summary> | ||
/// <param name="language"></param> | ||
void AddLanguage(string language); | ||
|
||
void ConfigureLink<T, U>(string name, Expression<Func<T, object>> from, Expression<Func<U, object>> to); | ||
|
||
/// <summary> | ||
/// Configures Content Types within the SourceConfigurationModel. | ||
/// </summary> | ||
/// <typeparam name="T">Generic content type.</typeparam> | ||
/// <returns></returns> | ||
SourceConfigurationModel<T> ConfigureContentType<T>() where T : class, new(); | ||
|
||
/// <summary> | ||
/// Configures Content Property Types within the SourceConfigurationModel. | ||
/// </summary> | ||
/// <typeparam name="T">Generic property type.</typeparam> | ||
/// <returns></returns> | ||
SourceConfigurationModel<T> ConfigurePropertyType<T>() where T : class, new(); | ||
|
||
/// <summary> | ||
/// Saves Content Types set in the SourceConfigurationModel to the Content Graph api. | ||
/// </summary> | ||
/// <returns></returns> | ||
Task<string> SaveTypesAsync(); | ||
|
||
/// <summary> | ||
/// Saves dynamic content sent in data array to the Content Graph api. | ||
/// </summary> | ||
/// <typeparam name="T"></typeparam> | ||
/// <param name="generateId">Id associated with content.</param> | ||
/// <param name="data">Dynamic data being saved to Content Graph.</param> | ||
/// <returns></returns> | ||
Task<string> SaveContentAsync<T>(Func<T, string> generateId, string language, params T[] data) where T : class, new(); | ||
|
||
/// <summary> | ||
/// Removes content previously stored by source. | ||
/// </summary> | ||
/// <returns></returns> | ||
Task<string> DeleteContentAsync(); | ||
|
||
/// <summary> | ||
/// Removes content previously stored by source. | ||
/// </summary> | ||
/// <returns></returns> | ||
Task<string> DeleteContentItemsAsync(string language, params string[] ids); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this interface might break existing customers. We could consider using an extension method instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be part of a new major version release. Since this is open source, I don't think we should stress about these breaking changes.