-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove infection class #140
Conversation
Remove more infection-class related files
Update ebola model default parameters
Hi @bahadzie please do not push directly to PRs opened by others. It's better to leave a reivew, and let the PR author make the changes. That allows the PR author to consider how best to resolve the review issues, to be aware of the changes made, and allows others to come in and comment as well. |
f01ed43
to
bb92bc5
Compare
Hi @bahadzie, just an update on this PR - I've hard reset this branch to bb92bc5, thanks for spotting that. cc-ing @Bisaloo as this could be a good time to add to the PR/code review/ section in the Blueprints. I have moved your other changes to the branch I would also suggest to not commit changes to the snapshot tests without being sure why the checks are failing. In this case, my best guess is that it was probably because you were running an older version of {testthat}. |
85c5157
to
bb92bc5
Compare
I'm forcing the branch to bb92bc5 again as I did last week, to remove the extra commits relating to accessors. This PR will be merged, unfortunately without review, once checks pass. The work on accessors can be found on the |
This PR removes the
<infection>
class, and moves infection related parameters to the models' function calls as arguments. All arguments have sensible default values rather than being missing. This fixes #133 and #114.Additionally this PR:
prob_discrete_erlang()
internal.