Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server keeps refreshing itself when failed to load music files #141

Closed
Colin5887 opened this issue Apr 17, 2021 · 5 comments
Closed

Server keeps refreshing itself when failed to load music files #141

Colin5887 opened this issue Apr 17, 2021 · 5 comments
Labels
Milestone

Comments

@Colin5887
Copy link

Here is how to trigger it:

  • Set up the LMS with everything by default
  • Set the Media root directory and do a scan so there is some music in it.
  • [Not sure if necessary] Go to pick some music and let it play. Just make sure your Play Queue is not empty.
  • [I'm not sure if it's important but] Do not shut the service down
  • Remove some music files, add some, rename some. Just do some changes to the music files.
  • Go to the web player page. It keeps refreshing.

I mean, it's okay to refresh the page when there are some errors. But it refreshes every second making it impossible to do another scan and fix everything. After like 10 minutes, I managed to:

  • Arrive at the Play Queue page and Clear everything.
  • Rename my music folder from /home/pi/Music to /home/pi/Music1
  • It eventually stops. I can finally do a Force Full Scan and everything is fixed.

Can we make the server do not refresh when it cannot play the music? It could do a force refresh and cleanup the database instead.

@Colin5887 Colin5887 changed the title Server keeps refreshing itself on a certain condition Server keeps refreshing itself when failed to load music files Apr 17, 2021
@Colin5887
Copy link
Author

I believe this is an issue because I need to update my music from time to time and I don't want it this hard because my operations are interrupted by page refreshing.

@epoupon
Copy link
Owner

epoupon commented Apr 17, 2021

Hmmm this is indeed not a normal behavior. What do you mean by refreshing?
Does the server actually stop and start every second? You can check that in the logs
Normally missing files are just skipped, I have to check if the "repeat all" option properly handle that case.

@epoupon epoupon added the bug label Apr 17, 2021
@Colin5887
Copy link
Author

Here is the log: https://drive.google.com/file/d/1u7AxaGoQgbr_vDGz8kuSklwKCeuL1fBP/view?usp=sharing
Sorry I can't attach the log on Github because You can't comment at this time — your comment is too long (maximum is 65536 characters).

@Colin5887
Copy link
Author

And by saying refreshing, I mean the web page behaves as if I pressed the F5 key.

@epoupon
Copy link
Owner

epoupon commented Apr 17, 2021

Thanks for your logs, I managed to reproduce/fix it.

@epoupon epoupon closed this as completed Apr 17, 2021
@epoupon epoupon modified the milestones: v3.26.0, v3.25.1 Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants