error: no template named 'optional' in namespace 'std'

[yurivict]

In file included from /disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/internal/InternalScrobbler.cpp:20:
In file included from /disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/internal/InternalScrobbler.hpp:22:
/disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/IScrobbler.hpp:46:59: error: no template named 'optional' in namespace 'std'
                        virtual void listenFinished(const Listen& listen, std::optional<std::chrono::seconds> duration) = 0;
                                                                          ~~~~~^
In file included from /disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/internal/InternalScrobbler.cpp:20:
/disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/internal/InternalScrobbler.hpp:33:51: error: no template named 'optional' in namespace 'std'
                        void listenFinished(const Listen& listen, std::optional<std::chrono::seconds> duration) override;
                                                                  ~~~~~^
/disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/internal/InternalScrobbler.hpp:26:8: warning: abstract class is marked 'final' [-Wabstract-final-class]
        class InternalScrobbler final : public IScrobbler
              ^
/disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/IScrobbler.hpp:46:17: note: unimplemented pure virtual method 'listenFinished' in 'InternalScrobbler'
                        virtual void listenFinished(const Listen& listen, std::optional<std::chrono::seconds> duration) = 0;
                                     ^
/disk-samsung/freebsd-ports/multimedia/lms/work/lms-3.25.0/src/libs/scrobbling/impl/internal/InternalScrobbler.cpp:44:21: error: out-of-line definition of 'listenFinished' does not match any declaration in 'Scrobbling::InternalScrobbler'
        InternalScrobbler::listenFinished(const Listen& listen, std::optional<std::chrono::seconds> duration)
                           ^~~~~~~~~~~~~~
1 warning and 3 errors generated.

Did you forget to include <optional>?

Version 3.25.0

[epoupon]

Hi!
Thanks for reporting this, indeed looks like a missing include.
Which freebsd version do you use?

[yurivict]

FreeBSD 12.2

[epoupon]

Could you by chance check if the b45b30d rev fixes the build?

[yurivict]

This patch fixes the include problem.