Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: ListenBrainz sync Favorites #163

Closed
Maxmystere opened this issue Jul 5, 2021 · 7 comments
Closed

feature request: ListenBrainz sync Favorites #163

Maxmystere opened this issue Jul 5, 2021 · 7 comments
Milestone

Comments

@Maxmystere
Copy link

It would be cool the have the possibility to sync musics star with ListenBrainz love/hate system

Possibilities could be star to love music or SetRating of 5 to love and 1 to hate

@epoupon epoupon added this to the v3.28.0 milestone Sep 29, 2021
@epoupon epoupon pinned this issue Sep 29, 2021
@epoupon
Copy link
Owner

epoupon commented Jan 6, 2022

Well I am quite puzzled about this one.
The feedback API endpoints (https://listenbrainz.readthedocs.io/en/production/dev/api/#feedback-api-endpoints) only work with MSID, which is useless (see https://listenbrainz.readthedocs.io/en/production/dev/feedback-json/#feedback-json-doc)
Note this endpoints seem to be used by the web interface of LB.
But the recording feedback recommandation API endpoints (https://listenbrainz.readthedocs.io/en/production/dev/api/#recording-recommendation-feedback-api-endpoints) work well with MBID, but "loved" tracks do not appear in the web interface.
Not sure what to do. Devs do not seem to answer, see:

@epoupon
Copy link
Owner

epoupon commented Jan 6, 2022

Some more link: metabrainz/listenbrainz-server#1794
Maybe MBIDs will eventually be supported on the feedback API endpoints

@Maxmystere
Copy link
Author

And there is no conversion possible between MSID and MBID ?
And is there any help i could provide ?
(I also saw that a dev replied to you on community metabrainz)

@epoupon
Copy link
Owner

epoupon commented Jan 10, 2022

Thanks for your help :)
Unfortunately I think we should just be patient and wait for the MBID be supported on this endpoint.
In the meanwhile I will make sure LMS is ready to handle this.

@epoupon epoupon modified the milestones: v3.28.0, v3.29.0 Jan 20, 2022
@epoupon epoupon unpinned this issue Jan 20, 2022
@Maxmystere
Copy link
Author

PR has been merged !

@epoupon
Copy link
Owner

epoupon commented May 29, 2022

Ok, just resurrected the branch, and I can confirm it is working as expected server (ListenBrainz) side:

  • we can submit a love/hate feedbacks using MBID and it shows up in their web interface
  • we can retrieve feedbacks and they are listed back with their MBID so we can match them LMS side.

@epoupon
Copy link
Owner

epoupon commented Jun 20, 2022

Fixed in #242
Note that removing a feedback (or a listen) on the server is not taken into account by lms. But this can be done in a second step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants