Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks without album does not show up in the UI & API correctly #165

Closed
kmod-midori opened this issue Jul 12, 2021 · 10 comments
Closed

Tracks without album does not show up in the UI & API correctly #165

kmod-midori opened this issue Jul 12, 2021 · 10 comments
Milestone

Comments

@kmod-midori
Copy link
Contributor

The files are generated from videos automatically, so the does not have album metadata set.
The artist entry is available in the web UI, but there is nothing in it, the same applies to the Subsonic API. However, clicking the "Play" button below the artist name does add all the files into the playlist.
image

example.zip

@epoupon
Copy link
Owner

epoupon commented Jul 12, 2021

Hello!
Yes indeed, in the artist page, only albums that are related to the artist are shown. A relation is one of composer, mixer, album artist, track artist, etc.
Technically all tracks in MB must belong to a release, but I admit this should be nice to support this.
We should find a way to show these relations and also tracks that are without albums.

@kmod-midori
Copy link
Contributor Author

In my case I probably can simply fill the album (release) field with the same video title and be done with it. But the page being empty yet here can confuse new users who do not have complete metadata in their libraries.

@epoupon epoupon pinned this issue Jul 27, 2021
@epoupon epoupon added this to the v3.27.0 milestone Jul 27, 2021
@epoupon
Copy link
Owner

epoupon commented Sep 3, 2021

Unfortunately there is one drawback though.
Currently the artist page is rendered once. There is no infinite scroll stuff.
Adding a "non album tracks" raises a problem: what should we do when there are too many tracks to display?
We could infinite scroll but it would make the bottom sections (similar artists, links) difficul to reach.
Any thoughts on this to get a proper layout?

@kmod-midori
Copy link
Contributor Author

kmod-midori commented Sep 3, 2021 via email

@garylaski
Copy link

What do you think about putting all tracks without an album into a group/psuedo-album called "[non album tracks]" in the way that Picard does for standalone recordings?

@epoupon
Copy link
Owner

epoupon commented Sep 4, 2021

@Glask1 : interesting idea indeed!
But after thinking a bit about it, I think it is rather a tagger problem than a player one.
I just discovered some picard/beets plugins that handle these non album tracks, maybe it would be best to just let users decide what to do and properly tag these tracks the way their wants.

@kmod-midori
Copy link
Contributor Author

Yes, I currently simply write the title to both title and album field, and that works well. However, it can still be confusing to show an empty screen with the play button functioning.

@epoupon
Copy link
Owner

epoupon commented Sep 4, 2021

You are right. And @Glask1's solution does not prevent users from tagging non album tracks as they want...

@kmod-midori
Copy link
Contributor Author

@Glask1 's idea is indeed interesting, but has a hidden problem: my individual tracks have embedded cover images, combining them into a single (virtual) album might mess that up.

@epoupon
Copy link
Owner

epoupon commented Sep 5, 2021

Maybe an acceptable solution would be to add a track list section with a manual "show more" button in order not to bloat the rendered page and make users still see the secondary stuff (similar stuff, links, etc.)

Edit: this would also apply for the albums of artists that have a very large amount of albums (lile Various Artists)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants