Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post scan report lists many duplicates but each recording ID appears only once #306

Closed
infinitejones opened this issue Feb 1, 2023 · 1 comment
Labels
Milestone

Comments

@infinitejones
Copy link

I have approx 80,000 files and following a full scan, the post-scan report says nearly 14,000 of them are duplicates. I know for sure that I don't have 14,000 duplicate files, and when searching the report file for the MBIDs, each of them only appears once.

LMS report

I would expect to find another instance of that MBID in the report, if that track really was a duplicate. Is that the expected behaviour of this report?

I'm not ruling out that there could be some duplicates in my collection, and I'd like to know what they are, but there are too many false negatives in the report currently and I'm not clear why.

Full report:
report.txt

@epoupon
Copy link
Owner

epoupon commented Feb 1, 2023

Well indeed there is a track/recording ID mixup here.
LMS searches for recording MBID duplicates but in the report this is the track MBID which is shown.
See for example:

/music/Ash/Nu-Clear Sounds/1-04 - Numbskull.flac (Recording MBID 42ed9f1e-5a47-3897-a590-17287a07a943) - Duplicated recording MBID
/music/Ash/Intergalactic Sonic 7s/1-19 - Numbskull.flac (Recording MBID d85b14de-d33b-3df3-b60d-039f009ea817) - Duplicated recording MBID

They all are from the same recording MBID: https://musicbrainz.org/recording/6452a1ca-1e1b-4b18-b223-d7727ac4bb26

But this is actually legit. We really should look for track MBID duplicates (not recording MBID duplicates)

@epoupon epoupon added the bug label Feb 1, 2023
@epoupon epoupon added this to the v3.36.0 milestone Feb 1, 2023
@epoupon epoupon closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants