Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] Can cause a crash if you accept a group invite, and sent a raid invite previously that was then accepted. #3048

Open
Aeadoin opened this issue Mar 6, 2023 · 0 comments
Assignees
Labels

Comments

@Aeadoin
Copy link
Contributor

Aeadoin commented Mar 6, 2023

Steps to reproduce:

  1. Invite Player 2 to raid.
  2. Send group invite from Player 2 to Player 1.
  3. Accept group invite on Player 1.
  4. Accept raid invite on Player 2.
  5. Results in EXCEPTION_ACCESS_VIOLATION in client_packet.cpp

Code where crash occurs:

if (group->members[x]) {
if (!client_to_add) {
if (group->members[x]->IsClient()) {

Most likely some sort of dangling pointer to group still exists, resulting in a crash when we try to deference group->members[x]->IsClient()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant