Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Taunt has multiple messages on success. #4257

Closed
noudess opened this issue Apr 15, 2024 · 4 comments
Closed

New Taunt has multiple messages on success. #4257

noudess opened this issue Apr 15, 2024 · 4 comments

Comments

@noudess
Copy link
Contributor

noudess commented Apr 15, 2024

On success:

[Mon Apr 15 09:36:10 2024] Auto attack is on.
[Mon Apr 15 09:36:10 2024] You try to crush a giant skeleton, but miss!
[Mon Apr 15 09:36:10 2024] You crush a giant skeleton for 18 points of damage.
[Mon Apr 15 09:36:10 2024] You bash a giant skeleton for 32 points of damage.
[Mon Apr 15 09:36:10 2024] You taunt a giant skeleton to ignore others and attack you!
[Mon Apr 15 09:36:11 2024] You taunt a giant skeleton to ignore others and attack you!

On failure:

[Mon Apr 15 09:36:28 2024] You taunt a giant skeleton to ignore others and attack you!
[Mon Apr 15 09:36:28 2024] You have failed to taunt your target.

The old system did not give you the same message twice on success. It did sometimes trigger the mob to speak up.

Do we want that back?

@fryguy503
Copy link
Contributor

Are we passing the message to the client or is it client controlled? I see the successful taunt mob message I'll teach you to interfere with me %3. if the target can speak, and the failed message. But not seeing the You taunt %s to ignore others and attack you!

@fryguy503
Copy link
Contributor

Oh I see, I was looking at the wrong branch - TAUNT_SUCCESS - Guessing the client is generating its own and we do not need to send it (My branch didn't have that call)

@fryguy503
Copy link
Contributor

#4258

@Kinglykrab
Copy link
Contributor

Resolved by #4258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants