[Fix] Adjust current position in MultiInvoker.executeOrder()

[kbrizzle]

Fixes sherlock-audit/2023-09-perennial-judging#61.

[github-actions]

[Payoff] Integration Test Code Coverage Report

Coverage after merging britz-review-fix-61 into main will be

100.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-payoff/contracts
PayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/interfaces
IPayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/payoff
Giga.sol	100%	100%	100%	100%
Kilo.sol	100%	100%	100%	100%
KiloPowerHalf.sol	100%	100%	100%	100%
KiloPowerTwo.sol	100%	100%	100%	100%
Mega.sol	100%	100%	100%	100%
MegaPowerTwo.sol	100%	100%	100%	100%
Micro.sol	100%	100%	100%	100%
MicroPowerTwo.sol	100%	100%	100%	100%
Milli.sol	100%	100%	100%	100%
MilliPowerHalf.sol	100%	100%	100%	100%
MilliPowerTwo.sol	100%	100%	100%	100%
Nano.sol	100%	100%	100%	100%
PowerHalf.sol	100%	100%	100%	100%
PowerTwo.sol	100%	100%	100%	100%

[github-actions]

[Payoff] Unit Test Code Coverage Report

Coverage after merging britz-review-fix-61 into main will be

100.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-payoff/contracts
PayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/interfaces
IPayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/payoff
Giga.sol	100%	100%	100%	100%
Kilo.sol	100%	100%	100%	100%
KiloPowerHalf.sol	100%	100%	100%	100%
KiloPowerTwo.sol	100%	100%	100%	100%
Mega.sol	100%	100%	100%	100%
MegaPowerTwo.sol	100%	100%	100%	100%
Micro.sol	100%	100%	100%	100%
MicroPowerTwo.sol	100%	100%	100%	100%
Milli.sol	100%	100%	100%	100%
MilliPowerHalf.sol	100%	100%	100%	100%
MilliPowerTwo.sol	100%	100%	100%	100%
Nano.sol	100%	100%	100%	100%
PowerHalf.sol	100%	100%	100%	100%
PowerTwo.sol	100%	100%	100%	100%

[github-actions]

[Oracle] Unit Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

79.25%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-oracle/contracts
Oracle.sol	100%	100%	100%	100%
OracleFactory.sol	100%	100%	100%	100%
packages/perennial-oracle/contracts/interfaces
IOracle.sol	100%	100%	100%	100%
IOracleFactory.sol	100%	100%	100%	100%
IPythFactory.sol	100%	100%	100%	100%
IPythOracle.sol	100%	100%	100%	100%
packages/perennial-oracle/contracts/pyth
PythFactory.sol	57.14%	31.82%	77.78%	72%	100, 106, 117, 44, 53, 60–61, 75, 84, 89, 89–91, 91, 91–92, 92, 92–93, 93, 93, 95
PythOracle_Arbitrum.sol	0%	100%	0%	0%	15, 20
PythOracle_Optimism.sol	0%	100%	0%	0%	15, 20
PythOracle.sol	52.89%	35.42%	73.33%	62.07%	114–115, 121, 121, 121, 132, 137–138, 144, 148–149, 151, 151, 151, 154, 154, 154, 177, 177, 177, 182–183, 186, 189, 189, 189–190, 193–194, 194, 194, 196, 196, 196–197, 197, 197–199, 199, 199, 199, 199, 201–203, 245, 66, 70, 76, 81, 83, 93

[github-actions]

[Extensions] Unit Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

80.56%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-extensions/contracts
MultiInvoker.sol	76.07%	69.77%	86.36%	78.57%	104, 144–145, 148–150, 152, 157, 226, 226–227, 229, 231, 240, 283, 283, 285, 288, 297, 297, 299, 302, 320, 322, 322, 322–323, 325, 330, 340–341, 344–345, 347, 384, 387–388, 388, 388–390, 390, 390, 392–393, 414, 420, 446, 463, 77, 80–82
packages/perennial-extensions/contracts/interfaces
IMultiInvoker.sol	100%	100%	100%	100%
packages/perennial-extensions/contracts/types
TriggerOrder.sol	78.26%	62.50%	100%	94.44%	34–35, 62–69

[github-actions]

[Vault] Unit Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

28.76%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-vault/contracts
Vault.sol	0%	0%	0%	0%	100, 106, 112–113, 121–122, 131, 133, 133, 133, 140, 142, 142, 142, 147, 147–148, 150–151, 151, 151, 154, 160, 160, 160–161, 161, 161, 163, 165–167, 174, 174–176, 184, 184, 184, 186–190, 195, 195–197, 203–204, 209, 209–212, 219, 219–221, 223–225, 238, 238–240, 242–245, 251–252, 252, 252–255, 257, 275, 275, 275–276, 276, 276, 279, 279, 279–281, 281, 281–283, 283, 283–285, 285, 285–287, 287, 287–289, 289, 289–290, 292, 292, 292, 295, 298–300, 303–305, 307, 321, 321, 321–323, 325, 325, 325, 330–331, 346, 350–353, 355, 361, 364, 364, 364, 367, 367, 367, 371–373, 386, 388, 388, 388, 388, 388, 390, 396–397, 397, 397–400, 400, 400–401, 408, 411, 413, 423, 437, 439–442, 444, 446–449, 452–453, 455–458, 461–466, 469–470, 473, 473, 473–475, 482, 482, 482–484, 491, 491, 491–493, 500, 500, 500, 502–505, 507, 507, 507–508, 508, 508, 508, 513, 519, 529–531, 539–540, 562–564, 570–572, 582–584, 586–588, 59, 59–60, 62–66, 72, 79, 86, 93
VaultFactory.sol	0%	0%	0%	0%	30–31, 35, 35–36, 48, 48–49, 52, 56–58, 60, 67–68
packages/perennial-vault/contracts/interfaces
IVault.sol	100%	100%	100%	100%
IVaultFactory.sol	100%	100%	100%	100%
packages/perennial-vault/contracts/lib
StrategyLib.sol	0%	0%	0%	0%	107–111, 114–115, 120, 123–124, 131, 144, 146, 149–150, 162–164, 173, 70–72, 74, 76–79, 82, 86, 88, 88, 88, 88, 88–89, 91, 93
packages/perennial-vault/contracts/types
Account.sol	100%	100%	100%	100%
Checkpoint.sol	100%	100%	100%	100%
Mapping.sol	100%	100%	100%	100%
Registration.sol	100%	100%	100%	100%
VaultParameter.sol	100%	100%	100%	100%

[github-actions]

[Oracle] Integration Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

78.62%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-oracle/contracts
Oracle.sol	37.50%	35.29%	41.67%	38.10%	110, 110, 110, 112–113, 113, 113, 115, 117, 117, 117–118, 125, 128–129, 129, 129, 131, 136, 136, 136–138, 20, 30, 37, 37–38, 40, 44–45, 52–53, 58, 63, 70, 70, 70–73, 73, 73–74, 76, 83, 88–89
OracleFactory.sol	58.33%	40.63%	70%	73.33%	103–105, 105, 105–106, 112, 112, 112–113, 33, 41, 48, 48–50, 57–59, 62, 73–75, 78, 85, 94–95
packages/perennial-oracle/contracts/interfaces
IOracle.sol	100%	100%	100%	100%
IOracleFactory.sol	100%	100%	100%	100%
IPythFactory.sol	100%	100%	100%	100%
IPythOracle.sol	100%	100%	100%	100%
packages/perennial-oracle/contracts/pyth
PythFactory.sol	89.29%	72.73%	100%	100%	106, 117, 44, 53, 60, 89
PythOracle_Arbitrum.sol	100%	100%	100%	100%
PythOracle_Optimism.sol	100%	100%	100%	100%
PythOracle.sol	98.35%	95.83%	100%	100%	132, 232

[github-actions]

[Core] Integration Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

91.92%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial/contracts
Market.sol	75.32%	53%	88.57%	85.55%	100–101, 106, 113, 120–122, 131, 133, 133, 133–134, 134, 134–136, 136, 136–137, 137, 137, 139, 146, 146, 146, 148–150, 155, 157–158, 160–161, 257–259, 403, 449, 489–490, 490, 490, 490, 499–500, 505–506, 508, 508, 508–509, 513, 519–520, 520, 529, 529, 529, 533, 538, 549, 555–556, 582–583, 60, 640, 645, 83, 92, 99, 99
MarketFactory.sol	69.70%	50%	83.33%	80%	37, 48, 57–58, 64, 66, 72, 75–76
packages/perennial/contracts/interfaces
IMarket.sol	100%	100%	100%	100%
IMarketFactory.sol	100%	100%	100%	100%
IOracleProvider.sol	100%	100%	100%	100%
IOracleProviderFactory.sol	100%	100%	100%	100%
IPayoffProvider.sol	100%	100%	100%	100%
packages/perennial/contracts/types
Global.sol	78.57%	50%	100%	100%	115–126
Invalidation.sol	60%	100%	66.67%	57.14%	28–30
Local.sol	80%	56.25%	83.33%	95.65%	128–133, 89, 97
MarketParameter.sol	69.57%	40.91%	100%	95%	113, 115–116, 118, 120, 122, 122, 122, 122, 134–138
OracleVersion.sol	100%	100%	100%	100%
Order.sol	89.74%	75%	100%	100%	109, 123, 74, 80
Position.sol	83.23%	56.25%	94.12%	95.89%	147–148, 211, 229, 286, 398–400, 467–469, 498–510
ProtocolParameter.sol	75%	50%	100%	100%	60–61, 67–71
RiskParameter.sol	72.41%	50%	100%	100%	143, 148, 153, 155, 160, 162, 164, 166, 168, 170, 180–185
Version.sol	90.18%	70.59%	100%	98.57%	192–193, 362–370

[github-actions]

[Extensions] Integration Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

99.31%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-extensions/contracts
MultiInvoker.sol	96.15%	89.53%	100%	100%	157, 226, 285, 299, 384, 388, 390, 414, 463
packages/perennial-extensions/contracts/interfaces
IMultiInvoker.sol	100%	100%	100%	100%
packages/perennial-extensions/contracts/types
TriggerOrder.sol	89.13%	83.33%	100%	94.44%	34–35, 62–64

[github-actions]

[Vault] Integration Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

99.02%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-vault/contracts
Vault.sol	97.55%	96.05%	97.22%	98.28%	209, 209–212, 292
VaultFactory.sol	89.47%	50%	100%	100%	35, 48
packages/perennial-vault/contracts/interfaces
IVault.sol	100%	100%	100%	100%
IVaultFactory.sol	100%	100%	100%	100%
packages/perennial-vault/contracts/lib
StrategyLib.sol	100%	100%	100%	100%
packages/perennial-vault/contracts/types
Account.sol	82.86%	50%	100%	100%	126–131
Checkpoint.sol	88.64%	68.75%	100%	100%	132, 186, 224–231
Mapping.sol	95.12%	80%	100%	100%	100, 95
Registration.sol	81.82%	50%	100%	100%	41–42
VaultParameter.sol	87.50%	50%	100%	100%	31

[github-actions]

[Core] Unit Test Coverage Report

Coverage after merging britz-review-fix-61 into main will be

99.78%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial/contracts
Market.sol	98.70%	96%	100%	100%	490, 490, 529, 83
MarketFactory.sol	100%	100%	100%	100%
packages/perennial/contracts/interfaces
IMarket.sol	100%	100%	100%	100%
IMarketFactory.sol	100%	100%	100%	100%
IOracleProvider.sol	100%	100%	100%	100%
IOracleProviderFactory.sol	100%	100%	100%	100%
IPayoffProvider.sol	100%	100%	100%	100%
packages/perennial/contracts/types
Global.sol	100%	100%	100%	100%
Invalidation.sol	100%	100%	100%	100%
Local.sol	95.56%	100%	83.33%	95.65%	97
MarketParameter.sol	100%	100%	100%	100%
OracleVersion.sol	100%	100%	100%	100%
Order.sol	100%	100%	100%	100%
Position.sol	100%	100%	100%	100%
ProtocolParameter.sol	100%	100%	100%	100%
RiskParameter.sol	100%	100%	100%	100%
Version.sol	100%	100%	100%	100%