Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latch #305

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Remove latch #305

merged 1 commit into from
Aug 5, 2022

Conversation

oysand
Copy link
Contributor

@oysand oysand commented Aug 5, 2022

No description provided.

@GodVenn
Copy link
Contributor

GodVenn commented Aug 5, 2022

Why? 🤔

@aeshub
Copy link
Contributor

aeshub commented Aug 5, 2022

The retain causes the latest message to be read when connecting to the broker. Whenever Flotilla connects to the broker this then creates an issue where messages related to previous missions on unknown robots are read. This is mostly an issue whenever we're testing and constantly recreating the database. However we risk getting an old message saying the robot is in a state which is not true based on this.

Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oysand oysand merged commit 71741f7 into equinor:main Aug 5, 2022
@oysand oysand deleted the remove-latch branch August 5, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants