Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure log-levels through env variables #316

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Configure log-levels through env variables #316

merged 3 commits into from
Aug 25, 2022

Conversation

phhuseboe
Copy link
Contributor

@phhuseboe phhuseboe commented Aug 24, 2022 •
edited by GodVenn
Loading

Closes #250

@phhuseboe
Copy link
Contributor Author

phhuseboe commented Aug 24, 2022 •
edited
Loading

Closes #250

@phhuseboe phhuseboe marked this pull request as ready for review August 24, 2022 12:31
GodVenn
GodVenn reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just see comment please

src/isar/config/settings.py Outdated Show resolved Hide resolved
@phhuseboe phhuseboe requested a review from GodVenn August 24, 2022 12:41
@eivindsjovold
Copy link
Contributor

LGTM

@GodVenn GodVenn linked an issue Aug 25, 2022 that may be closed by this pull request
Allow selecting log level for all threads in config #250
Closed
@GodVenn GodVenn removed a link to an issue Aug 25, 2022
Allow selecting log level for all threads in config #250
Closed
@phhuseboe phhuseboe merged commit 7d1e0ed into equinor:main Aug 25, 2022
@phhuseboe phhuseboe deleted the log-levels branch August 25, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindsjovold eivindsjovold eivindsjovold approved these changes

@GodVenn GodVenn Awaiting requested review from GodVenn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow selecting log level for all threads in config
3 participants
@phhuseboe @eivindsjovold @GodVenn