Use approved PSR-15 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build with 7.2 and nightly fails but the warnings seem not to be related to this PR. Something to do with |
Merged
shadowhand
suggested changes
Jan 23, 2018
src/Handler.php
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace Equip\Dispatch; | |||
|
|
|||
| use Interop\Http\Server\RequestHandlerInterface; | |||
| use Psr\Http\Server\RequestHandlerInterface; | |||
There was a problem hiding this comment.
This should go after Psr\Http\Message for alphabetical listing.
src/HandlerProxy.php
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace Equip\Dispatch; | |||
|
|
|||
| use Interop\Http\Server\RequestHandlerInterface; | |||
| use Psr\Http\Server\RequestHandlerInterface; | |||
There was a problem hiding this comment.
Also here and elsewhere.
tests/TestCase.php
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| use Eloquent\Phony\Mock\Handle\InstanceHandle; | |||
| use Eloquent\Phony\Phpunit\Phony; | |||
| use Interop\Http\Server\MiddlewareInterface; | |||
| use Psr\Http\Server\MiddlewareInterface; | |||
There was a problem hiding this comment.
Again, alpha ordering of use statements.
|
Uh. Somehow I failed the rebase and did normal merge from master with fixed conflict. The extra commit message could be hidden with squash merging the PR if needed? |
shadowhand
approved these changes
Jan 23, 2018
|
Thanks. I'll try to get this merged in later today and tagged. |
|
Super. Thanks! |
|
Tagged as version 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to the approved version of PSR-15.