Rename classes and add more tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schnittstabil objections to any of this? |
Stack is actually a middleware pipe. DelegateToCallableAdapter is actually a proxy. Refs #4
Create a common test case and test delegate separately. Since delegate handles most of the work, most of the testing should happen there.
All of these are used in the base test case, not in actual tests.
shadowhand
force-pushed
the
fix/renames
branch
from
206dfac
to
bc424e6
Compare
Closed
|
LGTM – I really like the adapter-to-proxy rename. FWIW, dispatching and pipe management can be separated, because those have different concerns: $pipe = new MiddlewarePipe($middlewares);
// …
$pipe->append(…);
$pipe->prepend(…);
// …
$dispatcher = new Dispatcher($pipe, $default);
$response = $dispatcher->dispatch(ServerRequest::fromGlobals());– However, maybe, it's a bit too over-engineered… |
|
Hmm, just one further thought: A Thus, an |
|
I don't see a need for it right now, especially if it explicitly depends on |
|
Released in 0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename classes by intent and test each class separately.